D18972: Format EXIF photo flash data

Nathaniel Graham noreply at phabricator.kde.org
Tue Feb 12 21:09:55 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> formatstrings.cpp:103
> +    const QMap<int, QString> flashTranslation = {
> +        { 0x00, i18nc("Description of photo flash", "No flash")                                                      },
> +        { 0x01, i18nc("Description of photo flash", "Fired")                                                         },

Does this one mean "present but did not fire" or "there is no flash with this hardware"? If the latter, I might suggest instead "None". Otherwise this is fine the way it is.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18972

To: astippich, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/7901b610/attachment.html>


More information about the Kde-frameworks-devel mailing list