D18604: Implement support for writing rating information for taglib writer

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Feb 5 21:55:57 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwriter.cpp:229
> No. Mp3 supports ID3v1, ID3v2 or Ape tags, so simply casting to ID3v2 is not possible.

but in case file.tag() returns an ApeTag, the dynamic_cast will return a nullptr. This is a dynamic_cast, not a static_cast.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190205/e5bd83c9/attachment.html>


More information about the Kde-frameworks-devel mailing list