D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwriter.cpp:229
> Is this the same as
> 
>   auto id3Tags = dynamic_cast<TagLib::ID3v2::Tag*>(file.tag());
>   if (id3Tags) { ... }
> 
> ?

No. Mp3 supports ID3v1, ID3v2 or Ape tags, so simply casting to ID3v2 is not possible.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190205/1bec3daf/attachment-0001.html>