[sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

[Ben Cooksley]

On Fri, Feb 1, 2019 at 9:15 PM David Faure <faure at kde.org> wrote:
>
> I'll try to get around to debugging this, but I'm surprised by one thing:
> doesn't the same issue happen in KIO's own tests? It also has several tests
> that make use of KIO slaves directly, skipping KLauncher.

Indeed, I found it surprising as well.

Only thing I can think of is that the tests in KIO tell the slaves to
exit before it finishes itself and exits - while the tests in
plasma-integration don't do this.

>
> Ironically, the reason we skip klauncher is exactly to avoid this problem in
> the first place (kdeinit and klauncher would keep running after the test
> ended).

The CI tooling should eliminate the need to do this for the most part
as long as you don't try to launch them yourself, as it will launch
kdeinit as part of the environment setup process :)
https://invent.kde.org/sysadmin/ci-tooling/blob/master/helpers/run-tests.py#L156

Thanks,
Ben

>
> On lundi 21 janvier 2019 06:46:32 CET Ben Cooksley wrote:
> > Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley.
> > Committed on 21/01/2019 at 05:46.
> > Pushed by bcooksley into branch 'master'.
> >
> > Disable execution of tests for plasma-integration.
> > This is necessary to ensure CI nodes do not become blocked due to hanging
> > tests withing plasma-integration.
> >
> > Currently, plasma-integration has several tests that make use of KIO slaves
> > directly (skipping KLauncher). Unfortunately, they do not terminate the
> > slaves prior to the conclusion of the test, resulting in the kioslave
> > processes being left around afterwards. This is a condition that CTest will
> > not tolerate, leading to it waiting indefinitely for these processes to
> > exit - and in turn blocking all other builds on the CI node in question.
> > While this is not a major issue in the case of Linux builds, it can quickly
> > become a severe condition in the case of FreeBSD and Windows builds due to
> > those builders being fixed rather than dynamically allocated.
> >
> > This class of issue (CTest waiting due to resident processes being left
> > behind) has been a major issue as of late and is quickly leading to the CI
> > system becoming unmaintainable due to the level of breakage. Should it be
> > necessary to ensure the maintainability of the system, withdrawal of
> > execution of tests for all projects is an option currently under
> > consideration.
> >
> > CCMAIL: plasma-devel at kde.org
> > CCMAIL: kde-frameworks-devel at kde.org
> > CCMAIL: release-team at kde.org
> > CCMAIL: kdevelop-devel at kde.org
> > CCMAIL: sysadmin at kde.org
> >
> > M  +2    -0    build-specs/Plasma/plasma-integration.yaml
> >
> > https://invent.kde.org/sysadmin/ci-tooling/commit/f6c79ff4787148459aa91c17d6
> > 83e4fd6a57c323
> >
> > diff --git a/build-specs/Plasma/plasma-integration.yaml
> > b/build-specs/Plasma/plasma-integration.yaml index 3d39455..159546c 100644
> > --- a/build-specs/Plasma/plasma-integration.yaml
> > +++ b/build-specs/Plasma/plasma-integration.yaml
> > @@ -1,5 +1,7 @@
> >  kf5-qt5:
> > +  run-tests: False
> >    force-inject-asan: True
> >
> >  stable-kf5-qt5:
> > +  run-tests: False
> >    force-inject-asan: True
>
>
> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>