D25877: [KColorschemeManager] Add option to reenable following global theme

Nathaniel Graham noreply at phabricator.kde.org
Thu Dec 26 15:13:26 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> asemke wrote in kcolorschememanager.cpp:107
> Yes, was also wrong in LabPlot. Just corrected https://invent.kde.org/kde/labplot/commit/262f37b59193ed88bf680b155dc6ecd37bd11419.
> 
> We should have maybe in this class only one public function KActionMenu *createSchemeSelectionMenu(QObject *parent) which internally sets the string to "Color Scheme" and the icon to "preferences-desktop-color". With this we'd enforce a consistent look. Or this is menu is automatically created for KXmlGuiWindow applications...

> Or this is menu is automatically created for KXmlGuiWindow applications...

That's what I was thinking of, yeah.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191226/91a5e3dd/attachment.html>


More information about the Kde-frameworks-devel mailing list