D17816: Support for xattrs on kio copy/move

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> copyxattrjob.cpp:98-111
> +	const int bsrc_fd = open(m_bsrc, 0);
> +	if (bsrc_fd < 0)
> +	{
> +        q->setErrorText(QLatin1String("failed to obtain file descriptor of source during xattr copy"));
> +        q->emitResult();
> +	}
> +    const QByteArray destination = QFile::encodeName(m_dest.toLocalFile());

indentation

> copyxattrjob.cpp:156-158
> +        vallen = fgetxattr(bsrc_fd, key.constData(), value.data(), valuelen, 0, 0);
> +#elif HAVE_SYS_EXTATTR
> +        vallen = extattr_get_file(m_bsrc, EXTATTR_NAMESPACE_USER, key.constData(), value.data(), valuelen);

valuelen there is no vallen

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise
Cc: anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191225/f4c55849/attachment-0001.html>