D26210: [KCoreAddons] Port QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added a comment.


  Looks good overall

INLINE COMMENTS

> klistopenfilesjob_unix.cpp:69
>          const QString out(QString::fromLocal8Bit(lsofProcess.readAll()));
> -        QStringList pidList = out.split(QRegExp(QStringLiteral("\\s+")), QString::SkipEmptyParts);
> +        QStringList pidList = out.split(QRegularExpression(QStringLiteral("\\s+")), QString::SkipEmptyParts);
>          pidList.removeDuplicates();

splitRef?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26210

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191224/cbe9b0aa/attachment.html>