D26210: [KCoreAddons] Port QRegExp to QRegularExpression
Ahmad Samir
noreply at phabricator.kde.org
Tue Dec 24 11:54:34 GMT 2019
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern()
to match the entire subject string.
KStringHandler::tagUrls(), make the regex slightly easier to read and capture
the whole matched url to use when calling QString::replace().
Note that KStringHandler::perlSplit(QRegExp... will have to be kept and
marked for deprecation, since it's called by some other apps in KDE.
A new perlSplit() overload should be added, possibly, just one perlSplit()
function that takes a QString, and a param indicating whether to treat it
as plain text or a regular expression.
TEST PLAN
make && ctest
REPOSITORY
R244 KCoreAddons
BRANCH
l-qregularexpression (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26210
AFFECTED FILES
autotests/krandomtest.cpp
src/lib/io/kfileutils.cpp
src/lib/text/kmacroexpander_unix.cpp
src/lib/text/kstringhandler.cpp
src/lib/util/klistopenfilesjob_unix.cpp
src/lib/util/kshell_win.cpp
To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191224/8b45d760/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list