D26129: Remove Iterator based loops for range based loops

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> ervin wrote in kconfig_compiler.cpp:2119
> This logic is very flawed... instead of comparing positions in the list now you're comparing actual values. If two different positions in the list would end up having the same values (for some reason) we'd generate syntactically incorrect code.

if two items in the list have the same values the KConfig XML is wrong and the generated code will not compile. I don't see an issue with it.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26129

To: tcanabrava, ervin
Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191223/02fa5214/attachment.html>