D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> slavebase.h:262
>       */
> -    enum MessageBoxType { QuestionYesNo = 1, WarningYesNo = 2, WarningContinueCancel = 3, WarningYesNoCancel = 4, Information = 5, SSLMessageBox = 6 };
> +    //In KMessageBox::DialogType; Sorry = 7, Error = 8, QuestionYesNoCancel = 9
> +    enum MessageBoxType { QuestionYesNo = 1, WarningYesNo = 2, WarningContinueCancel = 3, WarningYesNoCancel = 4, Information = 5, SSLMessageBox = 6, WarningContinueCancelDetailed = 10,  };

Does this break API docs generation? Suddenly the /** ... */ comment is separated from the enum.

> slavebase.h:1004
>       * @see PrivilegeOperationStatus
> -     * @since 5.43
> +     * @since 5.65
>       */

I was too slow, it's 5.66 now. Please change it everywhere.

Well by waiting we didn't break the message freeze with all these new i18n calls.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191214/013d44a5/attachment.html>