<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21783">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21783#inline-146466">View Inline</a><span style="color: #4b4d51; font-weight: bold;">slavebase.h:262</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">enum</span></span><span class="bright"> </span><span class="n"><span class="bright">MessageBoxType</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span><span class="bright"> </span><span class="n"><span class="bright">QuestionYesNo</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">WarningYesNo</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">WarningContinueCancel</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">3</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">WarningYesNoCancel</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">4</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Information</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">5</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">SSLMessageBox</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">6</span></span><span class="bright"> </span><span class="p"><span class="bright">};</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #74777d"><span class="bright">//In KMessageBox::DialogType; Sorry = 7, Error = 8, QuestionYesNoCancel = 9</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">enum</span> <span class="n">MessageBoxType</span> <span class="p">{</span> <span class="n">QuestionYesNo</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span><span class="p">,</span> <span class="n">WarningYesNo</span> <span style="color: #aa2211">=</span> <span style="color: #601200">2</span><span class="p">,</span> <span class="n">WarningContinueCancel</span> <span style="color: #aa2211">=</span> <span style="color: #601200">3</span><span class="p">,</span> <span class="n">WarningYesNoCancel</span> <span style="color: #aa2211">=</span> <span style="color: #601200">4</span><span class="p">,</span> <span class="n">Information</span> <span style="color: #aa2211">=</span> <span style="color: #601200">5</span><span class="p">,</span> <span class="n">SSLMessageBox</span> <span style="color: #aa2211">=</span> <span style="color: #601200">6</span><span class="p">,</span> <span class="n">WarningContinueCancelDetailed</span> <span style="color: #aa2211">=</span> <span style="color: #601200">10</span><span class="p">,</span>  <span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does this break API docs generation? Suddenly the /** ... */ comment is separated from the enum.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21783#inline-146467">View Inline</a><span style="color: #4b4d51; font-weight: bold;">slavebase.h:1004</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">     * @see PrivilegeOperationStatus</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d">     * @since 5.<span class="bright">43</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     * @since 5.<span class="bright">65</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">     */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I was too slow, it's 5.66 now. Please change it everywhere.</p>

<p style="padding: 0; margin: 8px;">Well by waiting we didn't break the message freeze with all these new i18n calls.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21783">https://phabricator.kde.org/D21783</a></div></div><br /><div><strong>To: </strong>chinmoyr, VDG, Frameworks, dfaure<br /><strong>Cc: </strong>mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns<br /></div>