D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I'm concerned that you didn't compile this (because of dependency issues, from what I gather), which means it's not tested either.
  
  I tried to compile it but it doesn't cleanly apply to git master. Can you rebase it?

INLINE COMMENTS

> slaveinterface.cpp:295
>              }
> +        } else if (m.contains("privilege_conf_details")) { // KF6 TODO Remove this conditional.
> +            d->privilegeConfMetaData = m;

This fails to build for me...

slaveinterface.cpp:291:55: error: ‘QString::QString(const char*)’ is private within this context

It needs QStringLiteral like the previous one.

> dfaure wrote in file_unix.cpp:87
> no space before ':' in English

Not done

> dfaure wrote in file_unix.cpp:91
> same

same

> dfaure wrote in file_unix.cpp:121
> weird indentation

still there

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191206/a20c2158/attachment.html>