D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

Chinmoy Ranjan Pradhan noreply at phabricator.kde.org
Fri Dec 6 16:46:26 GMT 2019


chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slaveinterface_p.h:56
> Please explain how, for when the time comes (in case you're not around to do it).

Removing each of its occurence (of which there are 3) and the surrounding `if`.  I will add comments where its needed to be removed.

> dfaure wrote in jobuidelegate.h:155
> what would be the proper API you have in mind?

I think adding a QString parameter for operation details should be sufficient. Then the API should be kept in sync with SlaveBase, SalveInterface, and JobUiDelegateExtension.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191206/91a6aed3/attachment.html>


More information about the Kde-frameworks-devel mailing list