D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 64855.
leinir marked 11 inline comments as done.
leinir added a comment.


  Address comments by @ahiemstra
  
  - Add a comment about why Button's configfile isn't aliased
  - Set the object ownership policy for QuickQuestionListener to cpp
  - std::make_shared for clarity, and a bit of debug categorisation
  - Simplify some whiley recursion, and use checkIndex()
  - Remember to check before setting properties to the same value
  - Actually require 5.11 (and sanitise some of the QtQuick imports)
  - Pull out the three delegate components
  - Add a wrapper component for CommentsModel
  - Use the new CommentsModel component

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=64465&id=64855

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  CMakeLists.txt
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/653895cd/attachment.html>