<table><tr><td style="">leinir updated this revision to Diff 64855.<br />leinir marked 11 inline comments as done.<br />leinir added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21721">View Revision</a></tr></table><br /><div><div><p>Address comments by <a href="https://phabricator.kde.org/p/ahiemstra/" style="

              border-color: #f1f7ff;

              color: #19558d;

              background-color: #f1f7ff;

                border: 1px solid transparent;

                border-radius: 3px;

                font-weight: bold;

                padding: 0 4px;">@ahiemstra</a></p>

<ul class="remarkup-list">

<li class="remarkup-list-item">Add a comment about why Button's configfile isn't aliased</li>

<li class="remarkup-list-item">Set the object ownership policy for QuickQuestionListener to cpp</li>

<li class="remarkup-list-item">std::make_shared for clarity, and a bit of debug categorisation</li>

<li class="remarkup-list-item">Simplify some whiley recursion, and use checkIndex()</li>

<li class="remarkup-list-item">Remember to check before setting properties to the same value</li>

<li class="remarkup-list-item">Actually require 5.11 (and sanitise some of the QtQuick imports)</li>

<li class="remarkup-list-item">Pull out the three delegate components</li>

<li class="remarkup-list-item">Add a wrapper component for CommentsModel</li>

<li class="remarkup-list-item">Use the new CommentsModel component</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D21721?vs=64465&id=64855">https://phabricator.kde.org/D21721?vs=64465&id=64855</a></div></div><br /><div><strong>BRANCH</strong><div><div>knsquick-feature-parity-with-kns (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21721">https://phabricator.kde.org/D21721</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

src/attica/atticaprovider.cpp<br />

src/attica/atticaprovider_p.h<br />

src/core/CMakeLists.txt<br />

src/core/author.cpp<br />

src/core/author.h<br />

src/core/commentsmodel.cpp<br />

src/core/commentsmodel.h<br />

src/core/engine.cpp<br />

src/core/engine.h<br />

src/core/entryinternal.cpp<br />

src/core/installation.cpp<br />

src/core/itemsmodel.cpp<br />

src/core/itemsmodel.h<br />

src/core/provider.h<br />

src/core/question.h<br />

src/qtquick/CMakeLists.txt<br />

src/qtquick/author.cpp<br />

src/qtquick/author.h<br />

src/qtquick/categoriesmodel.cpp<br />

src/qtquick/categoriesmodel.h<br />

src/qtquick/commentsmodel.cpp<br />

src/qtquick/commentsmodel.h<br />

src/qtquick/qml/Button.qml<br />

src/qtquick/qml/Dialog.qml<br />

src/qtquick/qml/DialogContent.qml<br />

src/qtquick/qml/DownloadItemsSheet.qml<br />

src/qtquick/qml/EntryDetails.qml<br />

src/qtquick/qml/NewStuffItem.qml<br />

src/qtquick/qml/NewStuffList.qml<br />

src/qtquick/qml/Page.qml<br />

src/qtquick/qml/QuestionAsker.qml<br />

src/qtquick/qml/private/ConditionalLoader.qml<br />

src/qtquick/qml/private/EntryCommentDelegate.qml<br />

src/qtquick/qml/private/EntryCommentsPage.qml<br />

src/qtquick/qml/private/EntryScreenshots.qml<br />

src/qtquick/qml/private/GridTileDelegate.qml<br />

src/qtquick/qml/private/Rating.qml<br />

src/qtquick/qml/private/Shadow.qml<br />

src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml<br />

src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml<br />

src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml<br />

src/qtquick/qmldir<br />

src/qtquick/qmlplugin.cpp<br />

src/qtquick/quickengine.cpp<br />

src/qtquick/quickengine.h<br />

src/qtquick/quickitemsmodel.cpp<br />

src/qtquick/quickitemsmodel.h<br />

src/qtquick/quickquestionlistener.cpp<br />

src/qtquick/quickquestionlistener.h<br />

tests/CMakeLists.txt<br />

tests/khotnewstuff-dialog-ui/main.qml<br />

tests/khotnewstuff-dialog.cpp</div></div></div><br /><div><strong>To: </strong>leinir, KNewStuff, VDG, Frameworks, ahiemstra<br /><strong>Cc: </strong>ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns<br /></div>