D23352: make button icons follow a reasonable size and layout

Marco Martin noreply at phabricator.kde.org
Wed Aug 28 10:02:16 BST 2019


mart added inline comments.

INLINE COMMENTS

> Button.qml:53
> +                id: icon
> +                anchors.centerIn: parent
> +                visible: parent.visible

no anchors and no enclosing Item.

This was ok as it was, including fillwidth/fillheight (perhaps)
but with the line:
Layout.preferredWidth: control.icon.width > 0 ? control.icon.width : -1
same for preferredHeight

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23352

To: camiloh, #plasma, mart, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/eaa99df8/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list