<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23352">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23352#inline-132816">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Button.qml:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">id: icon</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.fillWidth:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.fillHeight:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">tru</span>e</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="bright">    </span><span style="color: #aa4000"><span class="bright">anchors.centerIn:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">parent</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="bright">    </span><span style="color: #aa4000"><span class="bright">visible:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">parent</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visibl</span>e</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no anchors and no enclosing Item.</p>

<p style="padding: 0; margin: 8px;">This was ok as it was, including fillwidth/fillheight (perhaps)<br />
but with the line:<br />
Layout.preferredWidth: control.icon.width > 0 ? control.icon.width : -1<br />
same for preferredHeight</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23352">https://phabricator.kde.org/D23352</a></div></div><br /><div><strong>To: </strong>camiloh, Plasma, mart, ngraham<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns<br /></div>