D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Aug 5 17:32:47 BST 2019


apol created this revision.
apol added reviewers: Frameworks, Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Port to using the QImage::load() that takes a QIODevice and only do it when the
  execution is finished, instead of upon readyRead(). This makes sure that we are
  only processing the icon when is fully downloaded.
  
  BUG: 407409
  BUG: 400312

TEST PLAN
  Reproduced the bug and fixed it

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22952

AFFECTED FILES
  src/icon.cpp
  src/icon.h

To: apol, #frameworks, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190805/1fc5495f/attachment.html>


More information about the Kde-frameworks-devel mailing list