D19812: Add a web page to view and compare icons of different sizes
Filip Fila
noreply at phabricator.kde.org
Fri Apr 26 18:56:34 BST 2019
filipf added a comment.
In D19812#456848 <https://phabricator.kde.org/D19812#456848>, @ngraham wrote:
> What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This would be the perfect place to sneak in malware (not saying you or the author have done this, but that this kind of obfuscated code is a perfect vector for it).
I have to strongly second this sentiment. What's the source of the `vue.min.js` file? At the very least code shouldn't be formatted this way, and if this was the base file I'm seeing it's not in its original form: https://github.com/vuejs/vue/blob/dev/dist/vue.js
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D19812
To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: filipf, trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190426/9297c7c1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list