D19812: Add a web page to view and compare icons of different sizes

Yunhe Guo noreply at phabricator.kde.org
Fri Apr 26 18:53:01 BST 2019


guoyunhe added a comment.


  In D19812#456848 <https://phabricator.kde.org/D19812#456848>, @ngraham wrote:
  
  > What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This would be the perfect place to sneak in malware (not saying you or the author have done this, but that this kind of obfuscated code is a perfect vector for it).
  
  
  It is Vue, a MVC library to make interactive single page application. I can provide some examples:
  
  1. WordPress https://github.com/WordPress/WordPress/tree/master/wp-includes/js
  2. Bootstrap https://github.com/twbs/bootstrap/tree/master/dist/js
  3. Phabricator (this website) https://github.com/phacility/phabricator/blob/master/webroot/rsrc/externals/d3/d3.min.js
  
  They all have some minified JavaScript in Git repository.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190426/95b631fe/attachment.html>


More information about the Kde-frameworks-devel mailing list