D20766: Use appropriate background color for text previews

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Apr 23 14:08:23 BST 2019


kossebau added a subscriber: cfeck.
kossebau added a comment.


  Thanks for the patch. Hm, somehow I remember from my testing for D19432 <https://phabricator.kde.org/D19432> that highlighting color did not take active UI color theme into account, has that changed meanwhile?
  
  In any case, IMHO there should be first a decision whether thumbnails for plain text documents should be done taking the UI color theme into account, or should be similar to pdf, doc & Co, where usually a print out on paper is assumed for the look (at least by the native formats). Personally I would favour this, and the one doing the hard-coded background color (@cfeck) seems at one point done to have as well.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau
Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190423/9bb7d7c7/attachment.html>


More information about the Kde-frameworks-devel mailing list