<table><tr><td style="">kossebau added a subscriber: cfeck.<br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20766">View Revision</a></tr></table><br /><div><div><p>Thanks for the patch. Hm, somehow I remember from my testing for <a href="https://phabricator.kde.org/D19432" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D19432</a> that highlighting color did not take active UI color theme into account, has that changed meanwhile?</p>
<p>In any case, IMHO there should be first a decision whether thumbnails for plain text documents should be done taking the UI color theme into account, or should be similar to pdf, doc & Co, where usually a print out on paper is assumed for the look (at least by the native formats). Personally I would favour this, and the one doing the hard-coded background color (<a href="https://phabricator.kde.org/p/cfeck/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cfeck</a>) seems at one point done to have as well.</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20766">https://phabricator.kde.org/D20766</a></div></div><br /><div><strong>To: </strong>eshalygin, kossebau<br /><strong>Cc: </strong>cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov<br /></div>