D20169: Add profile support interface for TerminalInterface

Dominik Haumann noreply at phabricator.kde.org
Mon Apr 22 08:23:16 BST 2019


dhaumann added a comment.


  Please fix the API getters: in the KDE/Qt world, getters never start with 'get': just use availableProdiles() etc.
  
  Similarly, I suggest to rename changeCurrentProfile() to setCurrentProfile().
  
  Could you provide an updated patch?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190422/56e87595/attachment.html>


More information about the Kde-frameworks-devel mailing list