<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20169">View Revision</a></tr></table><br /><div><div><p>Please fix the API getters: in the KDE/Qt world, getters never start with 'get': just use availableProdiles() etc.</p>
<p>Similarly, I suggest to rename changeCurrentProfile() to setCurrentProfile().</p>
<p>Could you provide an updated patch?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R306 KParts</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20169">https://phabricator.kde.org/D20169</a></div></div><br /><div><strong>To: </strong>mschiller, hindenburg, Konsole, Frameworks, cfeck, hein<br /><strong>Cc: </strong>dhaumann, pino, michaelh, ngraham, bruns<br /></div>