D20644: Fix memory leak when reading some tar files
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Wed Apr 17 23:19:15 BST 2019
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> karchive.cpp:602
> Q_ASSERT(!d->rootDir); // Call setRootDir only once during parsing please ;)
> + delete d->rootDir; // but if it happens, try not to leak
> d->rootDir = rootDir;
:P don't try, do `//if it happens, don't leak`
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20644
To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190417/bf57bd81/attachment.html>
More information about the Kde-frameworks-devel
mailing list