D20283: [RFC] [SimpleKCM] Fix height calculation

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> SimpleKCM.qml:55
> +        + bottomPadding
> +        + (header && header.visible ? header.height + header.topPadding + header.bottomPadding : 0)
> +        + (footer && footer.visible ? footer.height + footer.topPadding + footer.bottomPadding : 0)

i don't think adding header.padding is correct here, also because in most cases it won't have sich a property.
also, header.implicitheight should be used, as size propagation from child to parent is always with implicitHeight (while height is from parent to child) otherwise gets binding loops

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190417/f2de124c/attachment-0001.html>