<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20283">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20283#inline-115949">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SimpleKCM.qml:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa2211">+</span> <span style="color: #004012">bottomPadding</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #004012">header</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">header</span><span class="p">.</span><span style="color: #004012">visible</span> <span style="color: #aa2211">?</span> <span style="color: #004012">header</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">header</span><span class="p">.</span><span style="color: #004012">topPadding</span> <span style="color: #aa2211">+</span> <span style="color: #aa4000">header.bottomPadding :</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #004012">footer</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">footer</span><span class="p">.</span><span style="color: #004012">visible</span> <span style="color: #aa2211">?</span> <span style="color: #004012">footer</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">footer</span><span class="p">.</span><span style="color: #004012">topPadding</span> <span style="color: #aa2211">+</span> <span style="color: #aa4000">footer.bottomPadding :</span> <span style="color: #601200">0</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">i don't think adding header.padding is correct here, also because in most cases it won't have sich a property.<br />
also, header.implicitheight should be used, as size propagation from child to parent is always with implicitHeight (while height is from parent to child) otherwise gets binding loops</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 KDeclarative</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20283">https://phabricator.kde.org/D20283</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, mart, broulik<br /><strong>Cc: </strong>broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>