D20558: Bug fix: find c++ stl using regex

[Aleix Pol Gonzalez]

apol added a comment.


  In D20558#450229 <https://phabricator.kde.org/D20558#450229>, @sh-zam wrote:
  
  > > Why are you using it without Android.cmake?
  >
  > I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` because of some variables as it expects to run as a toolchain.
  
  
  What does it mean that "it expects to run as a toolchain"?

INLINE COMMENTS

> ECMAndroidDeployQt.cmake:43
> +            # look for ++ and .so as in libc++.so
> +            string (REGEX MATCH "\"[^ ]+\\+\\+[^ ]*\.so\"" OUT ${VALUE})
> +            file(WRITE ${CMAKE_BINARY_DIR}/stl "${OUT}")

This looks quite awful. Why do you prefer using regex to string(FIND)? It could be something like
`string(FIND "${VALUE}" "c++.so\"" OUT)` if you want to be more specific.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190417/aa250a38/attachment.html>