<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20558">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D20558#450229" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D20558#450229</a>, <a href="https://phabricator.kde.org/p/sh-zam/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sh-zam</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Why are you using it without Android.cmake?</p></blockquote>
<p>I am building Krita and to add <tt style="background: #ebebeb; font-size: 13px;">create-apk</tt> target I am using <tt style="background: #ebebeb; font-size: 13px;">include (ECMAndroidDeployQt.cmake)</tt>, I can't use <tt style="background: #ebebeb; font-size: 13px;">Android.cmake</tt> because of some variables as it expects to run as a toolchain.</p></div>
</blockquote>
<p>What does it mean that "it expects to run as a toolchain"?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20558#inline-115905">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ECMAndroidDeployQt.cmake:43</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #304a96"><span class="bright">string</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">FIND</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"${VALUE}"</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">".so\"" OUT)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #766510"> <span class="bright">math(EXPR</span> OUT <span class="bright">"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">OUT</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">+4</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"</span>)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #766510"> <span class="bright">string(SUBSTRING "</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">VALUE</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">" 0 </span>${OUT}<span class="bright"> OUTSTR</span>)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #766510"> file(WRITE ${CMAKE_BINARY_DIR}/stl "</span><span style="color: #aa2211">${</span><span style="color: #001294">OUTSTR</span><span style="color: #aa2211">}</span><span style="color: #766510">")</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #74777d"><span class="bright"># look for ++ and .so as in libc++.so</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #304a96"><span class="bright">string</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">REGEX</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">MATCH</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"\"</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">[^</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">]+\\+\\+[^</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">]*\.so\</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">""</span></span> <span style="color: #766510">OUT</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">VALUE</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #304a96"><span class="bright">file</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">WRITE</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">CMAKE_BINARY_DIR</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">/stl</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"</span>${OUT}<span class="bright">"</span></span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This looks quite awful. Why do you prefer using regex to string(FIND)? It could be something like<br />
<tt style="background: #ebebeb; font-size: 13px;">string(FIND "${VALUE}" "c++.so\"" OUT)</tt> if you want to be more specific.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20558">https://phabricator.kde.org/D20558</a></div></div><br /><div><strong>To: </strong>sh-zam, apol<br /><strong>Cc: </strong>kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns<br /></div>