D20525: [InformationPanel] Use the new inline configuration mode

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Please bump the minimum required version for `KF5BalooWidgets` to 19.07.70.

INLINE COMMENTS

> informationpanelcontent.cpp:121
> +    connect(m_configureButtons, &QDialogButtonBox::accepted, this, [this]() {
> +                this->m_metaDataWidget->setConfigurationMode(Baloo::ConfigurationMode::Accept);
> +                m_configureButtons->setVisible(false);

Why `this->` only on this line? (I'd just remove it as it's unnecessary)

> informationpanelcontent.cpp:127
> +    connect(m_configureButtons, &QDialogButtonBox::rejected, this, [this]() {
> +                this->m_metaDataWidget->setConfigurationMode(Baloo::ConfigurationMode::Cancel);
> +                m_configureButtons->setVisible(false);

Same here

> informationpanelcontent.cpp:237
>  
> +void InformationPanelContent::configureShownProperties() {
> +    m_configureLabel->setVisible(true);

Coding style: brace should go to next line (the function below is also wrong...)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190414/b513d102/attachment.html>