<table><tr><td style="">elvisangelaccio requested changes to this revision.<br />elvisangelaccio added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20525">View Revision</a></tr></table><br /><div><div><p>Please bump the minimum required version for <tt style="background: #ebebeb; font-size: 13px;">KF5BalooWidgets</tt> to 19.07.70.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20525#inline-115530">View Inline</a><span style="color: #4b4d51; font-weight: bold;">informationpanelcontent.cpp:121</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">m_configureButtons</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QDialogButtonBox</span><span style="color: #aa2211">::</span><span class="n">accepted</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">m_metaDataWidget</span><span style="color: #aa2211">-></span><span class="n">setConfigurationMode</span><span class="p">(</span><span class="n">Baloo</span><span style="color: #aa2211">::</span><span class="n">ConfigurationMode</span><span style="color: #aa2211">::</span><span class="n">Accept</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">m_configureButtons</span><span style="color: #aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why <tt style="background: #ebebeb; font-size: 13px;">this-></tt> only on this line? (I'd just remove it as it's unnecessary)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20525#inline-115531">View Inline</a><span style="color: #4b4d51; font-weight: bold;">informationpanelcontent.cpp:127</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">m_configureButtons</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QDialogButtonBox</span><span style="color: #aa2211">::</span><span class="n">rejected</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">m_metaDataWidget</span><span style="color: #aa2211">-></span><span class="n">setConfigurationMode</span><span class="p">(</span><span class="n">Baloo</span><span style="color: #aa2211">::</span><span class="n">ConfigurationMode</span><span style="color: #aa2211">::</span><span class="n">Cancel</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">m_configureButtons</span><span style="color: #aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20525#inline-115532">View Inline</a><span style="color: #4b4d51; font-weight: bold;">informationpanelcontent.cpp:237</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">InformationPanelContent</span><span style="color: #aa2211">::</span><span class="n">configureShownProperties</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_configureLabel</span><span style="color: #aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style: brace should go to next line (the function below is also wrong...)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20525">https://phabricator.kde.org/D20525</a></div></div><br /><div><strong>To: </strong>bruns, Dolphin, Baloo, Frameworks, ngraham, astippich, VDG, elvisangelaccio<br /><strong>Cc: </strong>elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov<br /></div>