D20526: fix extracting of some properties to match what was writen
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sun Apr 14 15:08:30 BST 2019
bruns added a comment.
In D20526#449560 <https://phabricator.kde.org/D20526#449560>, @astippich wrote:
> IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much.
> How about inserting the TStringList entry by entry, without using the contactsFromString method? That would maintain the exact representation of metadata tags also for the baloo database.
When searching is left to baloo, it already splits up strings at whitespace etc., so you can provide the string as is.
As far as I can see, in some cases (e.g. "ARTIST"), the `Taglib::StringList PropertyMap::operator[]` is first joined (`.toString(';')`) and then split again. How about avoiding that in the first place?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20526
To: mgallien, astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190414/f3d3c84e/attachment.html>
More information about the Kde-frameworks-devel
mailing list