D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sat Apr 13 16:31:37 BST 2019


kossebau added inline comments.

INLINE COMMENTS

> iconitem.h:72
> -     */
> -    //KF6 Remove, this just shadows QQuickItem::smooth
> -    Q_PROPERTY(bool smooth READ smooth WRITE setSmooth NOTIFY smoothChanged)

Actually unsure about whether we can remove this, other than claimed in prepared commit message :)
But from what I saw in the code, this should be possible, as the name of the actual class which injects a property is nowhere stored/used on accessing the property, also saw no issues while test running this change.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20510

To: kossebau, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190413/f24a92c0/attachment.html>


More information about the Kde-frameworks-devel mailing list