D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  QQuickItem already has a "smooth" property, which was shadowed by the
  custom ones with the same name. As the property was not part of public
  symbols, but instead is dynamically looked up without the class name part
  of the property, we just remove the custom versions and instead switch
  all custom code to use the inherited property.
  
  While doing that the code is also fixed to properly update the
  textureNodes to the current value of the "smooth" property.
  As well as not set the filtering only on the texture, when it is passed
  to a texturenode which will set its own filtering state to the texture
  right before the bind call and thus wipe any previous direct setting
  of the filter mode on the texture.
  
  This also changed the default to smooth=true for SvgItem, though
  effectively smooth was always true, as the texturenode was hardcoded
  to get a QSGTexture::Linear filtering (which, as said above, is forced
  onto its texture, no matter what was otherwise set before).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dropsmoothoverrideproperty

REVISION DETAIL
  https://phabricator.kde.org/D20510

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h
  src/declarativeimports/core/svgitem.cpp
  src/declarativeimports/core/svgitem.h

To: kossebau, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190413/aac47554/attachment.html>