D20197: Fix desktop link to file or directory

[David Faure]

dfaure added a comment.


  Ah! So "DirOrFile" means the user can see and choose both directories and files? Maybe call this ModeWasDirAndFile. I kept reading this was "mode was dirs or mode was files" (which made me say "what else is there?"), while now I think I understand it means "mode was (both dir+files)", right?
  
  Won't this additional popup be annoying for other applications using KUrlRequester? I'm afraid that one use case where it makes sense, pollutes other use cases.
  Can you confirm it only shows up when saving, and when the mode is "dir+files"?

INLINE COMMENTS

> kurlrequester.cpp:255
>  
> +    void fileDialogHelper()
> +    {

I'd call this createFileDialog()

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190407/1863f0ff/attachment-0001.html>