D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis added a comment.


  In D15853#334415 <https://phabricator.kde.org/D15853#334415>, @pstefan wrote:
  
  > In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme. 
  >  You will have to run the scripts "apply-stylesheet.sh" and "currentColorFillFix.sh" –from here <https://github.com/KDE/plasma-framework/tree/master/src/tools>– with your files as arguments. You will need the program "xmlstarlet" as dependency. 
  >  Or, if these scripts do not work correctly, you'll have to do it by hand. I will take icons-dark/devices/16/drive-harddisk.svg as an example.
  >  You'd need to copy line 2-9 from the old file to the new file. You would also need to change the fill to "fill:currentColor", and then add the "class="ColorScheme-Text" ". But if you are lucky the script will work and you won't need to do a thing :)
  >
  > PS somewhere there's a script that changes the color of your monochrome automagically to the dark variant. So you don't have to do it by hand.
  
  
  Ouch, I was not aware of this. All of the other monochrome icons I made that have been committed to master probably lack this as as well. It would be nice to have all the required info for making icons on a wiki somewhere. The icon HIG doesn't say anything about this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180930/c0a2f85e/attachment-0001.html>