D15853: Change drive-harddisk to more adaptable style

[Phil Stefan]

pstefan requested changes to this revision.
pstefan added a comment.
This revision now requires changes to proceed.


  In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme. 
  You will have to run the scripts "apply-stylesheet.sh" and "currentColorFillFix.sh" –from here <https://github.com/KDE/plasma-framework/tree/master/src/tools>– with your files as arguments. You will need the program "xmlstarlet" as dependency. 
  Or, if these scripts do not work correctly, you'll have to do it by hand. I will take icons-dark/devices/16/drive-harddisk.svg as an example.
  You'd need to copy line 2-9 from the old file to the new file. You would also need to change the fill to "fill:currentColor", and then add the "class="ColorScheme-Text" ". But if you are lucky the script will work and you won't need to do a thing :)
  
  PS somewhere there's a script that changes the color of your monochrome automagically to the dark variant. So you don't have to do it by hand.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180930/405ceb0b/attachment.html>