D15714: add a string suffix to test data and use for unicode testing of taglibwriter

Stefan Brüns noreply at phabricator.kde.org
Fri Sep 28 21:50:46 BST 2018


bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwritertest.cpp:73
> Can this give failures on windows similar to D14122 <https://phabricator.kde.org/D14122>?

Yes, probably.
Although, this gives also a pointer to a different approach:

  // Add some unicode characters, use codepoints to avoid any issues with 
  // source encoding: "€µ"
  static const QChar data[4] = { 0x20ac, 0xb5 };
  QString unicodeTestStringSuffix(data, 2);

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180928/1750a2d7/attachment.html>


More information about the Kde-frameworks-devel mailing list