D15714: add a string suffix to test data and use for unicode testing of taglibwriter

Alexander Stippich noreply at phabricator.kde.org
Fri Sep 28 21:17:14 BST 2018


astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:73
> If safeguarding against bad editors is really necessary, better do it here.
> Alternatively, you can use C++11 unicode string literals, e.g.
> `QString(u"€")`
> If you save that one as e.g. latin1 and try to compile it, gcc reports:
> 
>   error: converting to execution character set: Invalid or incomplete multibyte or wide character
>        QString a{u"�"};

Can this give failures on windows similar to D14122 <https://phabricator.kde.org/D14122>?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180928/e00e5e9c/attachment.html>


More information about the Kde-frameworks-devel mailing list