D15704: increase test coverage of taglibwriter
Alexander Stippich
noreply at phabricator.kde.org
Mon Sep 24 19:10:56 BST 2018
astippich added inline comments.
INLINE COMMENTS
> svuorela wrote in taglibwriter.cpp:22
> Unrelated. but consider making this static ?
Never really though about that, but should be static, yes. None of the writers and extractors I looked at currently do this, so if I find time I will do that for all at once and separately
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D15704
To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180924/604dde82/attachment.html>
More information about the Kde-frameworks-devel
mailing list