D15704: increase test coverage of taglibwriter

Sune Vuorela noreply at phabricator.kde.org
Sun Sep 23 18:49:24 BST 2018


svuorela added a comment.


  Looks good to me. A nice and simple way to drastically increase test coverage.

INLINE COMMENTS

> taglibwriter.cpp:22
>  {
>      QStringList types = {
>          QStringLiteral("audio/mpeg"),

Unrelated. but consider making this static ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15704

To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180923/9c7bb9ed/attachment.html>


More information about the Kde-frameworks-devel mailing list