D15714: add a string suffix to test data and use for unicode testing of taglibwriter
James Smith
noreply at phabricator.kde.org
Sun Sep 23 23:35:11 BST 2018
smithjd added inline comments.
INLINE COMMENTS
> taglibwritertest.cpp:60
>
> - QCOMPARE(extractedTitle, QStringLiteral("Title1"));
> - QCOMPARE(extractedArtist, QStringLiteral("Artist1"));
> - QCOMPARE(extractedAlbum, QStringLiteral("Album1"));
> + QCOMPARE(extractedTitle, QString(QStringLiteral("Title1") + stringSuffix));
> + QCOMPARE(extractedArtist, QString(QStringLiteral("Artist1") + stringSuffix));
Is wrapping in a QString necessary?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D15714
To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180923/c14381a1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list