D15714: add a string suffix to test data and use for unicode testing of taglibwriter
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sun Sep 23 22:08:40 BST 2018
bruns added inline comments.
INLINE COMMENTS
> svuorela wrote in taglibwritertest.cpp:66
> yeah. given you write and read it, if somehow it gets encoded e.g. as iso-8859-15 rather than utf8, the euro sign would be encoded as 0xa4 rather than 0x20ac.
>
> As you write and read it in the same sequence, there is a possibiliyt for this to pass when it shouldn't.
>
> Unfortunately roundtripping the files with bad editors can make this happen. Especially on windows.
This should be covered by the read tests. The read tests use binary artifacts.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D15714
To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180923/724d8fed/attachment.html>
More information about the Kde-frameworks-devel
mailing list