D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 41815.
leinir added a comment.


  After discovering that the previous version of this patch had introduced a binary incompatibility, and panicking momentarily that this had been done in a release, Jonathan reverted it (as i was away for a bit and unable to do so myself). The patch here attempts to fix the BIC issue, while also readjusting the logic for how the tag filters reach the provider. It is now done directly by the provider itself, rather than through each search request. While this does introduce that nasty d-pointer hack, it also makes more logical sense that the Provider itself holds the information (as that's where those filters are directly relevant). So, nasty surprise to find out i'd caused things to break, but the end result is, i think, kind of better anyway (even though it introduces that todo for kf-next).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6513?vs=41133&id=41815

REVISION DETAIL
  https://phabricator.kde.org/D6513

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/entryinternal.h
  src/core/provider.cpp
  src/core/provider.h
  src/core/tagsfilterchecker.cpp
  src/core/tagsfilterchecker.h
  src/staticxml/staticxmlprovider.cpp
  tests/CMakeLists.txt
  tests/khotnewstuff_test-ui/main.qml
  tests/khotnewstuff_test-ui/main.qmlc
  tests/khotnewstuff_test.knsrc.in
  tests/knewstuff2_test.cpp
  tests/knewstuff2_test.h
  tests/knewstuff2_test.knsrc
  tests/testdata/entry.xml
  tests/testdata/provider.xml

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180917/9e80ece3/attachment.html>