D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir reopened this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  In D6513#326519 <https://phabricator.kde.org/D6513#326519>, @rikmills wrote:
  
  > In D6513#326071 <https://phabricator.kde.org/D6513#326071>, @ngraham wrote:
  >
  > > FYI, this included an ABI change to `SearchRequest` that broke Discover: https://bugs.kde.org/show_bug.cgi?id=398412
  >
  >
  > I see this revision has been reverted in master in 293ae2448f54fd1b1f7cacc86cd40b30a3fb087d <https://phabricator.kde.org/R304:293ae2448f54fd1b1f7cacc86cd40b30a3fb087d>
  
  
  It has. I am currently (bar the odd break for a cup of tea) knee deep in house renovations, but i will be reopening this when i work out what to do to make this not ABI incompatible. In the meantime, suggestions for achieving the least hacky approach would be appreciated.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180915/b6777144/attachment.html>