D15451: Let KUrlCombo operate on QIcon instead of QPixmap

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Sep 12 15:10:26 BST 2018


broulik created this revision.
broulik added reviewers: Frameworks, dfaure, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Lets the view load the correctly scaled icon on demand.

TEST PLAN
  Before
  F6256160: Screenshot_20180912_155136.png <https://phabricator.kde.org/F6256160>
  After
  F6256162: Screenshot_20180912_160656.png <https://phabricator.kde.org/F6256162>
  
  `KIO::pixmapForUrl` and `KIconLoader::loadMimeTypeIcon` says something about "loading additional icon themes" but they're hardly used in KIO anymore so it's likely the file list itself would have a hard time finding the icons anyway, so we can just use `QIcon::fromTheme` here

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15451

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: broulik, #frameworks, dfaure, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180912/020aefe8/attachment.html>


More information about the Kde-frameworks-devel mailing list