D15328: kfilewidget: convert connect syntax

Anthony Fieroni noreply at phabricator.kde.org
Fri Sep 7 12:13:57 BST 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:1225
>      // the KDirOperator's view-selection in there
> -    QObject::disconnect(locationEdit, SIGNAL(editTextChanged(QString)),
> -                        q, SLOT(_k_slotLocationChanged(QString)));
> +    QObject::disconnect(m_connEditTextChanged);
>  

Whenever disconnect after that reset connection to QMetaObject::Connection cause disconnect empty connection is safe, double disconnect same one - does not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180907/afc3a2f6/attachment.html>


More information about the Kde-frameworks-devel mailing list