D15180: kioexecd: watch for creations or modifications of the temporary files

[Jaime Torres Amate]

jtamate added a comment.


  May I commit or should I wait for @elvisangelaccio to accept the changes? This time I have read the arc message, that is usually something about non tracked files:
  Revision 'D15180 <https://phabricator.kde.org/D15180>: kioexecd: watch for creations or modifications of the temporary files' has not been accepted. Continue anyway? [y/N]
  
  > Even better use the std::remove_if/std::erase pattern, which avoids O(n^2) complexity during erase.
  > Or in this specific case, std::partition/{iterate over removed}/std::erase
  
  I assume QMap is like a std::map. I've seen in this cppreference page <https://en.cppreference.com/w/cpp/algorithm/remove> that these algorithms cannot be used with associative containers such as std::set and std::map.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: bruns, anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180905/2ad1524d/attachment.html>