D15180: kioexecd: watch for creations or modifications of the temporary files

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Sep 5 15:35:46 BST 2018


bruns added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kioexecd.cpp:134
> Also for loop should looks like:
> 
>   for (it = begin(); it != end();) {
>       if () {
>           it = erase(it);
>       } else {
>           ++it;
>       }
>   }

Even better use the std::remove_if/std::erase pattern, which avoids O(n^2) complexity during erase.
Or in this specific case, std::partition/{iterate over removed}/std::erase

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: bruns, anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180905/d04f0934/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list