D16490: [KFileMetaData] Add unittest for XML extractor

[Luca Beltrame]

lbeltrame added a comment.


  Generally looks OK to me, one note on `QDir::separator()` usage.

INLINE COMMENTS

> xmlextractortest.cpp:38
> +{
> +    return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + QDir::separator() + fileName;
> +}

IIRC you shouldn't use `QDir::separator()`.  See http://agateau.com/2015/qdir-separator-considered-harmful/

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181029/dfd210f9/attachment.html>